Skip to content

add Red language #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add Red language #62

wants to merge 5 commits into from

Conversation

loziniak
Copy link
Member

@loziniak loziniak commented Nov 28, 2022

Added a test case similar to the one added to tokei. It includes comments inside strings, but probably that's not supported, so I'll probably delete this after checking what CI says.

@loziniak
Copy link
Member Author

I don't get why these lines are cut out:

x: 1
x: 2
x: 3

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just looked like it was "off".

Comment on lines 11 to 13
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's intentional, but perhaps hard to deal with for the extractor. should it be seen as an extractor bug instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line should be left anyway, but it's not. It's not "off".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course it is, inside a herdoc string. Sorry about that. I did not look closely enough to get the context.

@ErikSchierboom
Copy link
Member

@loziniak Let me know when you are happy for this to be merged (CI is failing right now)

@loziniak
Copy link
Member Author

It seems I found a bug in extractor - #63 , so perhaps it's better to wait until this PR can be tested by CI.

@joshiraez
Copy link
Collaborator

Looking at the issues

@joshiraez
Copy link
Collaborator

Ok, I just replied to both of them. We can continue the discussion there and keep iterating together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants